-
Notifications
You must be signed in to change notification settings - Fork 391
fix(cli): Use ethers as max_fee unit in submit to aligned
#1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MarcosNicolau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems ok. wip testing.
Also this probably needs documentation changes
uri-99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed comments
JulianVentura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and worked as expected locally
Co-authored-by: Urix <[email protected]>
User ethers as unit in
max_feefor submit to alignedDescription
Use ethers as
max_feeunit in submit to aligned.To Test:
max_feedenominated inethersType of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging