Skip to content

feat: add mainnet values to sdk #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 3 commits into from
Dec 3, 2024
Merged

feat: add mainnet values to sdk #1536

JuArce merged 3 commits into from
Dec 3, 2024

Conversation

@uri-99
Copy link
Contributor

@uri-99 uri-99 commented Nov 29, 2024

Add mainnet values to sdk

Description

this pr adds mainnet to network and networkArg, and also their addresses in the respective get addresses

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce merged commit c91fe97 into testnet Dec 3, 2024
3 checks passed
@JuArce JuArce deleted the hotfix-add-mainnet-to-sdk branch December 3, 2024 13:40
MarcosNicolau pushed a commit that referenced this pull request Dec 5, 2024
@uri-99 @JuArce @MarcosNicolau
feat: add mainnet values to sdk (#1536)
436ce43 
Co-authored-by: Julian Arce <[email protected]>
MarcosNicolau added a commit that referenced this pull request Dec 5, 2024
@MarcosNicolau
Revert "feat: add mainnet values to sdk (#1536)"
f8de225 
This reverts commit 436ce43.
PatStiles pushed a commit that referenced this pull request Dec 6, 2024
@uri-99 @JuArce @PatStiles
feat: add mainnet values to sdk (#1536)
a3a5a65 
Co-authored-by: Julian Arce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+3 more reviewers

@Oppen Oppen Oppen approved these changes

@PatStiles PatStiles PatStiles approved these changes

@JulianVentura JulianVentura JulianVentura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@uri-99 @Oppen @PatStiles @JulianVentura @JuArce @MarcosNicolau