Skip to content

ci: address clippy warnings #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcosNicolau merged 1 commit into from
Nov 28, 2024
Merged

ci: address clippy warnings #1515

MarcosNicolau merged 1 commit into from
Nov 28, 2024

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Nov 28, 2024 •
edited
Loading

Description

Address clippy warnings on ci.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau changed the title chore: address clippy warnings ci: address clippy warnings Nov 28, 2024
@MarcosNicolau MarcosNicolau added this pull request to the merge queue Nov 28, 2024
Merged via the queue into staging with commit ddaf233 Nov 28, 2024
3 checks passed
@MarcosNicolau MarcosNicolau deleted the fix/ci-clippy branch November 28, 2024 15:39
avilagaston9 pushed a commit that referenced this pull request Nov 29, 2024
@MarcosNicolau @avilagaston9
ci: address clippy warnings (#1515)
caa2dbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

+4 more reviewers

@PatStiles PatStiles PatStiles approved these changes

@uri-99 uri-99 uri-99 approved these changes

@JulianVentura JulianVentura JulianVentura approved these changes

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MarcosNicolau @PatStiles @uri-99 @JulianVentura @JuArce @avilagaston9