fix: flush batcher queue only when needed #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcos Nicolau <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]>
Member
MarcosNicolau
left a comment
MarcosNicolau
left a comment
There was a problem hiding this comment.
Works alright, but we should merge it with #1507 as it is a dependency.
…from-queue-until-they-are-accepted-on-chain' into 1510-fix-flush-batcher-queue-only-when-needed
Co-authored-by: Avila Gastón <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]>
Co-authored-by: Avila Gastón <[email protected]>
…from-queue-until-they-are-accepted-on-chain' into 1510-fix-flush-batcher-queue-only-when-needed
17 tasks
MarcosNicolau
approved these changes
Nov 28, 2024
Member
MarcosNicolau
left a comment
MarcosNicolau
left a comment
There was a problem hiding this comment.
Tested on macos, works as expected.
avilagaston9
approved these changes
Nov 28, 2024
Contributor
avilagaston9
left a comment
avilagaston9
left a comment
There was a problem hiding this comment.
Works in my machine!
Oppen
reviewed
Nov 28, 2024
Oppen
reviewed
Nov 28, 2024
JuArce
approved these changes
Nov 29, 2024
avilagaston9
added a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Julian Ventura <[email protected]> Co-authored-by: avilagaston9 <[email protected]> Co-authored-by: Marcos Nicolau <[email protected]> Co-authored-by: Marcos Nicolau <[email protected]> Co-authored-by: Avila Gastón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush batcher queue only when necessary
Note
This pr includes the content of #1507.
Description
Modifies the batcher queue's behavior when encountering an error during task creation. Instead of flushing the entire queue by default, the logic now checks the error type. We only flush when the transaction reverted due to:
SubmissionInsufficientBalanceGenericType of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging