Skip to content

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented Nov 27, 2024

Improve grafana layout and bug fixes on metrics querying

Description

  • Show dashboard with a better distribution

  • Some queries were using counters incorrectly

How to Test

  1. Run all the components

  2. make run_metrics

  3. Go to grafana dashboard localhost:3000

  4. Grafana should show metrics correctly

Type of change

  • Bug fix
  • Refactor

Checklist

  • Linked to Github Issue

@JuArce JuArce self-assigned this Nov 27, 2024
@JuArce JuArce marked this pull request as ready for review November 28, 2024 13:35
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent!

@JuArce JuArce mentioned this pull request Nov 28, 2024
2 tasks
@JuArce JuArce added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
Copy link
Contributor

@JulianVentura JulianVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic and seems to be working fine!

@JuArce JuArce added this pull request to the merge queue Nov 28, 2024
Merged via the queue into staging with commit 052ac25 Nov 28, 2024
1 check passed
@JuArce JuArce deleted the 1509-refactor-change-grafana-dashboard branch November 28, 2024 17:08
avilagaston9 pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants