refactor: remove_proofs_from_queue called after submit is OK #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Co-authored-by: Marcos Nicolau <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]>
MarcosNicolau
approved these changes
Nov 27, 2024
Member
MarcosNicolau
left a comment
MarcosNicolau
left a comment
There was a problem hiding this comment.
Work as expected, great job! 🚀
PatStiles
approved these changes
Nov 27, 2024
MarcosNicolau
approved these changes
Nov 27, 2024
Member
MarcosNicolau
left a comment
MarcosNicolau
left a comment
There was a problem hiding this comment.
Still works fine with newest changes!
JuArce
reviewed
Nov 27, 2024
| batch_state_lock.update_user_proof_count(addr, *proof_count)?; | ||
| batch_state_lock.update_user_max_fee_limit(addr, *max_fee_limit)?; | ||
| batch_state_lock.update_user_total_fees_in_queue(addr, *total_fees_in_queue)?; | ||
| batch_state_lock |
Collaborator
There was a problem hiding this comment.
Does this process leave a consistent state?
14 tasks
Co-authored-by: Avila Gastón <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]>
Co-authored-by: Avila Gastón <[email protected]>
Collaborator
|
Supersedes by #1512 |
JuArce
deleted the
1505-refactor-batcher-shouldnt-remove-submitted-proofs-from-queue-until-they-are-accepted-on-chain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Contents of this PR are included in this pr
Leaving this PR as draft so we can visualize the diff, and the comments
Remove proofs from queue only after createNewTask succeeded
Description
This PR removes the sent proofs from the batcher queue only after the submition to eth was succesful.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging