fix: parse error codes from createNewTask ethereum contract function #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batcher/aligned-batcher/src/lib.rs
Outdated
Comment on lines
1277
to
1286
|
|
||
| // TODO: Here we have to match and handle the errors and flush the queue if necessary | ||
| // NoProofSubmitters | ||
| // NoFeePerProof | ||
| // InsufficientFeeForAggregator | ||
| // SubmissionInsufficientBalance | ||
| // BatchAlreadySubmitted | ||
| // InsufficientFunds | ||
| // OnlyBatcherAllowed | ||
| // Generic |
Member
There was a problem hiding this comment.
I would create a separate issue here
Contributor
There was a problem hiding this comment.
Removed! This will be handle in a future PR
Comment on lines
17
to
18
| // TODO: Here we are missing the modifiers: onlyWhenNotPaused | ||
| // TODO: Parse parameters from error responses |
Contributor
|
tested on local devnet and it worked as expected. |
PatStiles
approved these changes
Nov 27, 2024
| &byte_string[..10] // Extract the error code only | ||
| } else { | ||
| "" // Not gonna match | ||
| }; |
Contributor
There was a problem hiding this comment.
Try let str_code = e.to_string().get(..10).unwrap_or("");
Contributor
There was a problem hiding this comment.
It's working now. Maybe in a future refactor
avilagaston9
approved these changes
Nov 27, 2024
Contributor
avilagaston9
left a comment
avilagaston9
left a comment
There was a problem hiding this comment.
Works in my machine!
uri-99
approved these changes
Nov 27, 2024
avilagaston9
added a commit
that referenced
this pull request
Nov 29, 2024
…1503) Co-authored-by: Julian Ventura <[email protected]> Co-authored-by: avilagaston9 <[email protected]> Co-authored-by: Urix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse error codes from
createNewTaskDescription
This PR adds parsing errors on batcher from the
createNewTaskfunction on ethereumBatcherPaymentServicecontractAnother PR will be made to add handling of modifiers
onlyWhenNotPausedwhenNotPaused, as well as improve the parsing of some revert errors by parsing the returned args.How to test
You will have to repeat this for each error:
createNewTaskfromBatcherPaymentServiceorAlignedServiceManagerto revert with an error handled in this PRmake anvil_deploy_aligned_contractsType of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging