Fix multiple fk issue with PostgreSQL migrations #1010
Conversation
| refMap = Map.fromList $ foldl ref [] cols | ||
| where ref rs c = case cReference c of | ||
| Nothing -> rs | ||
| (Just r) -> (unDBName $ cName c, r) : rs |
There was a problem hiding this comment.
Here we build a map of column names to foreign keys, so we can pass that on to getColumn.
| ,"AND kcu.table_name=? " | ||
| ,"AND kcu.column_name=?"] | ||
| ,"AND kcu.column_name=? " | ||
| ,"AND tc.constraint_name=?"] |
There was a problem hiding this comment.
We now use the reference name to filter the query.
|
Tests seem to be failing for |
|
Looks like newer versions of the |
|
Try merging master - there's an upper bound in place to prevent the cabal solver from picking that version. |
robbassi
force-pushed
the
fix-migration-multiple-fk
branch
from
06fceec to
feb00e6
Compare
This commit adds a (failing) test case for when multiple foreign key constraints exist on a single column.
|
@parsonsmatt thanks! |
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks!
| , T.unpack (unDBName cname) | ||
| , " but got: " | ||
| , show xs | ||
| ] |
There was a problem hiding this comment.
❤️ great error message!
4 participants
This PR addresses issue #1009 for the PostgreSQL backend. In order to support multiple foreign keys on a single column, we now pass the reference name to
getColumn, and use it in the where clause when querying foreign keys for the column.Before submitting your PR, check that you've:
After submitting your PR: