Fix buffer size check in cpp-preproc.c when reading lines with fgets#271
Open
pps83 wants to merge 1 commit intoyasm:masterfrom
Open
Fix buffer size check in cpp-preproc.c when reading lines with fgets#271pps83 wants to merge 1 commit intoyasm:masterfrom
pps83 wants to merge 1 commit intoyasm:masterfrom
Conversation
Author
|
Without this fix long lines case yasm to deadlock |
Author
|
@PeterJohnson please take a look |
fgets reads at most bufsize-1 chars, the check for the full buffer has to account for the trailing NULL char. This code matches line reading code of gas-preproc.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fgets reads at most bufsize-1 chars, the check for the full buffer has to account for the trailing NULL char. This code matches line reading code of gas-preproc.c