refactor: remove unnecessary checks#6955
Merged
arcanis merged 3 commits intoyarnpkg:masterfrom Feb 5, 2019
DanielRuf:chore/remove-unnecessary-checks
Merged
refactor: remove unnecessary checks#6955arcanis merged 3 commits intoyarnpkg:masterfrom DanielRuf:chore/remove-unnecessary-checks
arcanis merged 3 commits intoyarnpkg:masterfrom
DanielRuf:chore/remove-unnecessary-checks
Conversation
Contributor
Author
|
I guess the Git resolver change is related to #3449. |
Contributor
Author
DanielRuf
changed the title
Contributor
Author
|
Why do the CI checks fail? |
Member
|
Restarting, but they looked pretty scary. Maybe related to the registry failures from past week? |
arcanis
requested changes
Jan 29, 2019
Member
|
Thanks 👍 |
cacheflow
added a commit
to cacheflow/yarn
that referenced
this pull request
Feb 14, 2019
* master: (67 commits) Include key info for "expected hoisted" invariant (yarnpkg#7009) refactor: remove unnecessary checks (yarnpkg#6955) fix: drive letter casing for win32 pnp (yarnpkg#7007) Don’t call `release` with an exit code (yarnpkg#6981) Check os and platform even when engines is not present in package.json (yarnpkg#6976) Fix handling of non-offline errors (yarnpkg#6968) Treat the ignore-scripts in yarnrc as a synonym to the cli arg (yarnpkg#6983) fix(pnp): make sure pnp module is again the first preloaded module. (yarnpkg#6951) refactor: remove unused imports (yarnpkg#6956) Add 1.14.0 to changelog (yarnpkg#6967) 1.15.0-0 v1.14.0 Fix suggested command after unlinking a package (yarnpkg#6931) Update CHANGELOG.md fix(pnp): make sure pnp module is the first preloaded module. (yarnpkg#6942) fix(pnp): make sure that the package locator is fetched with a trailing slash (yarnpkg#6882) Improve rendering of Chocolatey package description (yarnpkg#6899) Fixing dynamic require missing from webpack (yarnpkg#6908) feat(policies): Use github access token when requesting releases (yarnpkg#6912) Fixes PnP detection across workspaces (yarnpkg#6878) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are two checks which are not needed. One check in a condition was added when the Facebook headers were removed and there is no reasons for the
falsecheck.Test plan