Skip to content

Fix suggested command after unlinking a package#6931

Merged
arcanis merged 5 commits intoyarnpkg:masterfrom
justinsacbibit:master
Jan 23, 2019
Merged

Fix suggested command after unlinking a package#6931
arcanis merged 5 commits intoyarnpkg:masterfrom
justinsacbibit:master

Conversation

@justinsacbibit
Copy link
Copy Markdown
Contributor

Fixes #937, #1957

Summary

After unlinking a package, yarn suggests running yarn to re-install the package, but it doesn't actually end up re-installing the package. yarn install --check-files or yarn install --force is required.

Test plan

Not needed

@ryankeener
Copy link
Copy Markdown

I think this is a very valuable PR but I think it's more of a workaround than a "fix" for #937 & #1957

@arcanis arcanis merged commit 48b0bee into yarnpkg:master Jan 23, 2019
@arcanis
Copy link
Copy Markdown
Member

arcanis commented Jan 23, 2019

Thanks 👍

cacheflow added a commit to cacheflow/yarn that referenced this pull request Feb 14, 2019
* master: (67 commits)
  Include key info for "expected hoisted" invariant (yarnpkg#7009)
  refactor: remove unnecessary checks (yarnpkg#6955)
  fix: drive letter casing for win32 pnp (yarnpkg#7007)
  Don’t call `release` with an exit code (yarnpkg#6981)
  Check os and platform even when engines is not present in package.json (yarnpkg#6976)
  Fix handling of non-offline errors (yarnpkg#6968)
  Treat the ignore-scripts in yarnrc as a synonym to the cli arg (yarnpkg#6983)
  fix(pnp): make sure pnp module is again the first preloaded module. (yarnpkg#6951)
  refactor: remove unused imports (yarnpkg#6956)
  Add 1.14.0 to changelog (yarnpkg#6967)
  1.15.0-0
  v1.14.0
  Fix suggested command after unlinking a package (yarnpkg#6931)
  Update CHANGELOG.md
  fix(pnp): make sure pnp module is the first preloaded module. (yarnpkg#6942)
  fix(pnp): make sure that the package locator is fetched with a trailing slash (yarnpkg#6882)
  Improve rendering of Chocolatey package description (yarnpkg#6899)
  Fixing dynamic require missing from webpack (yarnpkg#6908)
  feat(policies): Use github access token when requesting releases (yarnpkg#6912)
  Fixes PnP detection across workspaces (yarnpkg#6878)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants