fix linkDuplicates for symlinks#5442
Conversation
connectdotz
changed the title
|
the test-macos-node6 and test-macos-node8 have been stuck over 20 hours... looks like the other PR have suffered the similar fate for 4 days... can someone from the yarn core team take a look of the task queue...? |
|
good, tests finally unstuck. @bestander @rally25rs, I didn't see reviewer assigned for this, just wondering if we can get some traction |
|
Love it! Thank you, @connectdotz. |
address yarnpkg#5442
* fix nohoist binLink address #5442 * fix test path * fix test for symlink verification on windows platform * add test to verify top-level package binLink
|
@arcanis is there a planned 1.5.2 release? If so, can we include this change? It would make a world of difference for folks using workspaces. |
|
It should happen soonish but I can't give you an exact date. In the meantime, the nightlies are the recommended way to get features already merged in the trunk: https://yarnpkg.com/en/docs/nightly |
|
@arcanis -- Thank you for the response. I'm aware of the nightly build option but it's hard to prescribe that solution for a team of engineers. It would be nice if there could be a release cadence for yarn, maybe every 2 weeks? I believe that's what npm does. I say this just as a friendly suggestion and understanding that you all are probably quite busy :-) |
4 participants
Summary
addressing #5421.
src:
workspaces-nohoist-experimentalindependent of nohoist config in package.json.__tests__:
__tests__/commands/install/integration-deduping.jsand corresponding fixtures.Test plan