Skip to content

fix(CLI): Use process exit instead of exitCode for node < 4#5291

Merged
arcanis merged 2 commits intoyarnpkg:masterfrom
kaylie-alexa:fix-process
Jan 30, 2018
Merged

fix(CLI): Use process exit instead of exitCode for node < 4#5291
arcanis merged 2 commits intoyarnpkg:masterfrom
kaylie-alexa:fix-process

Conversation

@kaylie-alexa
Copy link
Copy Markdown
Member

Since node 0.10.x doesn't support process.exitCode, use process.exit for terminating when yarn is incompatible.

Summary

Fixes #5258

We have a rule to not use process.exit whenever possible, but since this particular command is specifically for determining node version compatibility (currently we don't support 0.12.x or 0.10.x) we should default back to process.exit.

Test plan
run yarn on node .10.x then echo $?

kaylie added 2 commits January 29, 2018 10:51
Since node 0.10 doesn't support process.exitCode, use process.exit
@arcanis arcanis merged commit aa855c5 into yarnpkg:master Jan 30, 2018
agoldis added a commit to agoldis/yarn that referenced this pull request Feb 2, 2018
…readdir_files

* upstream/master: (34 commits)
  feat(upgrade, add): Separately log added/upgraded dependencies (yarnpkg#5227)
  feat(publish): Publish command uses publishConfig.access in package.json (yarnpkg#5290)
  fix(CLI): Use process exit instead of exitCode for node < 4 (yarnpkg#5291)
  feat(cli): error on missing workspace directory (yarnpkg#5206) (yarnpkg#5222)
  feat: better error when package is not found (yarnpkg#5213)
  Allow scoped package as alias source (yarnpkg#5229)
  fix(cli): Use correct directory for upgrade-interactive (yarnpkg#5272)
  nohoist baseline implementation (yarnpkg#4979)
  1.4.1
  1.4.0
  Show current version, when new version is not supplied on "yarn publish" (yarnpkg#4947)
  fix(install): use node-gyp from homebrew npm (yarnpkg#4994)
  Fix transient symlinks overriding direct ones v2 (yarnpkg#5016)
  fix(auth): Fixes authentication conditions and logic with registries (yarnpkg#5216)
  chore(package): move devDeps to appropriate place (yarnpkg#5166)
  fix(resolution) Eliminate "missing peerDep" warning when dep exists at root level. (yarnpkg#5088)
  fix(cli): improve guessing of package names that contain a dot (yarnpkg#5102) (yarnpkg#5135)
  feat(cli): include notice with license when generating disclaimer (yarnpkg#5072) (yarnpkg#5111)
  feat(cli): group by license in licenses list (yarnpkg#5074) (yarnpkg#5110)
  feat(cli): improve error message when file resolver can't find file (yarnpkg#5134) (yarnpkg#5145)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants