Skip to content

feat(cli): improve error message when file resolver can't find file (#5134)#5145

Merged
arcanis merged 3 commits intoyarnpkg:masterfrom
iansu:fix-5134
Jan 15, 2018
Merged

feat(cli): improve error message when file resolver can't find file (#5134)#5145
arcanis merged 3 commits intoyarnpkg:masterfrom
iansu:fix-5134

Conversation

@iansu
Copy link
Copy Markdown
Contributor

@iansu iansu commented Jan 2, 2018

Summary

Improve the error message when the file resolver can't find the specified file.

Test plan

  • Create a package.json with a dependency that points to a non-existent file (file://noexist)
  • Run yarn
  • Observe that the error message says what the problem is and provides a command to resolve the issue

@buildsize
Copy link
Copy Markdown

buildsize Bot commented Jan 2, 2018

This change will decrease the build size from 10.4 MB to 10.39 MB, a decrease of 2.41 KB (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 900.37 KB 900.18 KB -195 bytes (0%)
yarn-[version].js 3.92 MB 3.92 MB -665 bytes (0%)
yarn-legacy-[version].js 4.06 MB 4.06 MB -694 bytes (0%)
yarn-v[version].tar.gz 906.1 KB 905.33 KB -785 bytes (0%)
yarn_[version]all.deb 669.31 KB 669.19 KB -130 bytes (0%)

@arcanis arcanis merged commit eaa9be8 into yarnpkg:master Jan 15, 2018
@arcanis
Copy link
Copy Markdown
Member

arcanis commented Jan 15, 2018

Thanks!

agoldis added a commit to agoldis/yarn that referenced this pull request Feb 2, 2018
…readdir_files

* upstream/master: (34 commits)
  feat(upgrade, add): Separately log added/upgraded dependencies (yarnpkg#5227)
  feat(publish): Publish command uses publishConfig.access in package.json (yarnpkg#5290)
  fix(CLI): Use process exit instead of exitCode for node < 4 (yarnpkg#5291)
  feat(cli): error on missing workspace directory (yarnpkg#5206) (yarnpkg#5222)
  feat: better error when package is not found (yarnpkg#5213)
  Allow scoped package as alias source (yarnpkg#5229)
  fix(cli): Use correct directory for upgrade-interactive (yarnpkg#5272)
  nohoist baseline implementation (yarnpkg#4979)
  1.4.1
  1.4.0
  Show current version, when new version is not supplied on "yarn publish" (yarnpkg#4947)
  fix(install): use node-gyp from homebrew npm (yarnpkg#4994)
  Fix transient symlinks overriding direct ones v2 (yarnpkg#5016)
  fix(auth): Fixes authentication conditions and logic with registries (yarnpkg#5216)
  chore(package): move devDeps to appropriate place (yarnpkg#5166)
  fix(resolution) Eliminate "missing peerDep" warning when dep exists at root level. (yarnpkg#5088)
  fix(cli): improve guessing of package names that contain a dot (yarnpkg#5102) (yarnpkg#5135)
  feat(cli): include notice with license when generating disclaimer (yarnpkg#5072) (yarnpkg#5111)
  feat(cli): group by license in licenses list (yarnpkg#5074) (yarnpkg#5110)
  feat(cli): improve error message when file resolver can't find file (yarnpkg#5134) (yarnpkg#5145)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants