Adds support for _resolveFilename's option 'conditions' #6966
+42
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node.js added support for a
conditionsflag in_resolveFilename(and thus indirectlyrequire.resolve), but they forgot to document this new option. As a result our hook rightfully refuses to perform the resolution since it doesn't know what to do with this flag.This is more an issue when using the new
registerHookAPI because it then stops going into this codepath, causing aconditionsoption to always be injected.Vite recently started using this API as of 7.2.0, so it now crashes.
How did you fix it?
Adds support for the
conditionsoption (we already supported it, it's just that we weren't forwarding it, since Node.js didn't support it).Checklist