Skip to content

fix(pnp): support require(esm)#6639

Merged
arcanis merged 2 commits intomasterfrom
merceyz/fix/pnp-require-esm
Dec 28, 2024
Merged

fix(pnp): support require(esm)#6639
arcanis merged 2 commits intomasterfrom
merceyz/fix/pnp-require-esm

Conversation

@merceyz
Copy link
Copy Markdown
Member

@merceyz merceyz commented Dec 23, 2024

What's the problem this PR addresses?

Node.js supports require(esm) now so we can avoid throwing an error if support is enabled.

Fixes #6336
Ref nodejs/citgm#1086

How did you fix it?

Avoid throwing ERR_REQUIRE_ESM if process.features.require_module is truthy.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 3978649 into master Dec 28, 2024
@arcanis arcanis deleted the merceyz/fix/pnp-require-esm branch December 28, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: ERR_REQUIRE_ESM in Yarn PnP mode using Node.js 22 with --experimental-require-module flag

2 participants