Fix incorrect node:… module warnings in doctor#6347
Merged
arcanis merged 2 commits intoyarnpkg:masterfrom Jun 19, 2024
Merged
Conversation
This swaps to use `isBuiltin` from Node rather than constructing a custom set of module names with `node:` prefix. For some modules that didn't have a "bare" module (e.g. `node:test`) this fixes false positive errors. Closes yarnpkg#6343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This swaps to use
isBuiltinfrom Node rather than constructing a custom set of module names withnode:prefix. For some modules that didn't have a "bare" module (e.g.node:test) this fixes false positive errors.What's the problem this PR addresses?
Closes #6343
How did you fix it?
Checklist