fix(core): set npm_package_json environment variable when running scripts#4546
Merged
arcanis merged 9 commits intoyarnpkg:masterfrom Jul 12, 2022
uhop:master
Merged
fix(core): set npm_package_json environment variable when running scripts#4546arcanis merged 9 commits intoyarnpkg:masterfrom uhop:master
npm_package_json environment variable when running scripts#4546arcanis merged 9 commits intoyarnpkg:masterfrom
uhop:master
Conversation
merceyz
changed the title
npm_package_json environment variable when running scripts
merceyz
requested changes
Jun 13, 2022
This was referenced Jun 13, 2022
Contributor
Author
Co-authored-by: Kristoffer K. <[email protected]>
Member
|
I've updated the implementation to get the |
merceyz
previously approved these changes
Jul 12, 2022
arcanis
reviewed
Jul 12, 2022
Contributor
Author
Member
|
All good - thanks @uhop ! 🌟 |
merceyz
added a commit
that referenced
this pull request
Jul 20, 2022
…cripts (#4546) * Added `packageLocation` as a base for `npm_package_json`. * Added docs. * The release decisions. * chore: versions * Update packages/gatsby/content/advanced/lifecycle-scripts.md Co-authored-by: Kristoffer K. <[email protected]> * refactor: get `packageLocation` from the linkers * test: update expected script environment variables * chore: changelog * Update scriptUtils.ts Co-authored-by: merceyz <[email protected]> Co-authored-by: Maël Nison <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Implements
$npm_package_json. Closes #2436How did you fix it?
Updated
scriptUtils.makeScriptEnvto populate thenpm_package_jsonenvironment variable.The location of every package root, wherepackage.jsonresides, is already calculated. I added a way to expose it as$npm_package_json:*makeScriptEnv()ofscriptUtils.tsgets an optional parameterpackageLocation.* If it is supplied, it is joined usingppath.join()withpackage.jsonand exposed as$npm_package_json.*packageLocationcomes frominitializePackageEnvironment()(the same file), where it finds it usinglinker.findPackageLocation().Checklist