fix: address pkgConf parsing bug outlined in #37 (#45)

bcoe · web-flow · commit be76ee6e602b · 2016-08-08T21:40:00.000-07:00
diff --git a/index.js b/index.js
@@ -351,7 +351,8 @@ function parse (args, opts) {
 
     // Set normalized value when key is in 'normalize' and in 'arrays'
     if (checkAllAliases(key, flags.normalize) && checkAllAliases(key, flags.arrays)) {
-      value = path.normalize(val)
+      if (Array.isArray(val)) value = val.map(path.normalize)
+      else value = path.normalize(val)
     }
 
     var splitKey = key.split('.')
diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -2025,4 +2025,14 @@ describe('yargs-parser', function () {
       parsed.error.message.should.equal('banana')
     })
   })
+
+  // see: https://github.com/yargs/yargs-parser/issues/37
+  it('normalizes all paths in array when provided via config object', function () {
+    var argv = parser([ '--foo', 'bar' ], {
+      array: ['a'],
+      normalize: ['a'],
+      configObjects: [{'a': ['bin/../a.txt', 'bin/../b.txt']}]
+    })
+    argv.a.should.deep.equal(['a.txt', 'b.txt'])
+  })
 })

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,8 @@ function parse (args, opts) {`
`351`	`351`
`352`	`352`	`// Set normalized value when key is in 'normalize' and in 'arrays'`
`353`	`353`	`if (checkAllAliases(key, flags.normalize) && checkAllAliases(key, flags.arrays)) {`
`354`		`- value = path.normalize(val)`
	`354`	`+ if (Array.isArray(val)) value = val.map(path.normalize)`
	`355`	`+ else value = path.normalize(val)`
`355`	`356`	`}`
`356`	`357`
`357`	`358`	`var splitKey = key.split('.')`