fix: nargs was consuming too many arguments

Benjamin · Benjamin · commit 4fef20615ab0 · 2018-01-20T15:02:12.000-08:00
diff --git a/index.js b/index.js
@@ -315,7 +315,7 @@ function parse (args, opts) {
 
     if (available < toEat) error = Error(__('Not enough arguments following: %s', key))
 
-    for (ii = i + 1; ii < (available + i + 1); ii++) {
+    for (ii = i + 1; ii < (Math.min(available, toEat) + i + 1); ii++) {
       setArg(key, args[ii])
     }
 
diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -1653,6 +1653,16 @@ describe('yargs-parser', function () {
 
       result.error.message.should.equal('Not enough arguments following: foo')
     })
+
+    it('should not consume more than configured nargs', function () {
+      var result = parser(['--foo', 'a', 'b'], {
+        narg: {
+          foo: 1
+        }
+      })
+
+      result.foo.should.eql('a')
+    })
   })
 
   describe('env vars', function () {

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ function parse (args, opts) {`
`315`	`315`
`316`	`316`	`if (available < toEat) error = Error(__('Not enough arguments following: %s', key))`
`317`	`317`
`318`		`- for (ii = i + 1; ii < (available + i + 1); ii++) {`
	`318`	`+ for (ii = i + 1; ii < (Math.min(available, toEat) + i + 1); ii++) {`
`319`	`319`	`setArg(key, args[ii])`
`320`	`320`	`}`
`321`	`321`