chore: improve build robustness#2554
Merged
Merged
Conversation
- pin GitHub actions - add package-lock.json - add CI test with updated direct dependencies - lint changes from updates
Member
Author
|
FYI: @wesleytodd Adding (Mentioned in nodejs/citgm#1106) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the last few years the builds have often been broken by in-range updates to dependencies, especially development dependencies. Add
package-lock.jsonto make the build more reliable. To reduce the risk of missing breakages introduced by updates to production dependencies (which will affect yargs users), added a CI job which updates the direct dependencies then runs the tests.