Fix heap corruption for strings larger than 2114 bytes#211
Merged
Conversation
- Replace RuneStrArray (LocalVector<RuneStr>) with std::vector<RuneStr> since LocalVector explicitly warns it's only safe for primitive types, not structs like RuneStr - Change loop counter in DecodeUTF8RunesInString from uint32_t to size_t to prevent integer overflow for very long strings, with an explicit overflow check before truncating to uint32_t for RuneStr fields - Update UnicodeTest.Test1 expected string to match std::vector operator<< format - Add MixSegmentTest.LongInput regression test for strings > 2114 bytes Co-authored-by: yanyiwu <[email protected]>
Copilot
AI
changed the title
[WIP] Fix corrupted size vs. prev_size error in jieba.cut
Fix heap corruption for strings larger than 2114 bytes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Processing strings longer than ~2114 bytes causes a
corrupted size vs. prev_sizeglibc malloc abort. The culprit isRuneStrArraybeing backed byLocalVector<struct RuneStr>— a container that explicitly documents it is only safe for primitive types, not structs.Changes
include/cppjieba/Unicode.hppRuneStrArrayfromlimonp::LocalVector<struct RuneStr>tostd::vector<RuneStr>DecodeUTF8RunesInStringloop counter fromuint32_t itosize_t ito eliminate infinite-loop risk on strings >4 GB; add explicit overflow guard before narrowing casts touint32_tfields inRuneStrtest/unittest/unicode_test.cpp— UpdateUnicodeTest.Test1expected string to matchstd::vector'soperator<<format (no extra element-wrapping quotes).test/unittest/segments_test.cpp— AddMixSegmentTest.LongInputregression test covering Chinese and ASCII inputs exceeding 2114 bytes.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.