Repository navigation
feat(workflow): form-binding service for Form View bindings - #1
Closed
yangzhang75 wants to merge 1 commit into
Closed
yangzhang75 wants to merge 1 commit into
yangzhang75 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
👋 Thanks for your first contribution to Texera, @yangzhang75! If you're looking for a good place to start, browse issues labeled You can drive common housekeeping yourself by commenting one of these commands on its own line:
Each command must match exactly: |
Automated Reviewer SuggestionsBased on the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Form View stack (parent issue apache#8011). Stacked on PR3 (apache#8275); base is
formview-pr3, so the diff shows only this slice.Adds
FormBindingService, the single reader/writer of a workflow's Form View definition. It resolves each exposed operator property against the live graph (flagging bindings whose operator or property is gone), reads and writes values through the samesetOperatorPropertyedit the operator canvas makes, and keeps the graph's view-result set in step with what the form promises to show. The definition is presentation only and never affects a run.Tests: 35, 100% statements / branches / functions.