Skip to content

Commit dac0dda

Browse files
authored
fix: remove /api/dataset/file endpoint (apache#4137)
<!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> This PR proposes to remove the unused `retrieveDatasetSingleFile()` endpoint (GET /api/dataset/file) which was allowing unauthenticated downloads of non-downloadable datasets. ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> The endpoint is introduced in the PR apache#2391 which adds dataset APIs to the webserver. Then it is modified in the PR apache#2719 which aims to remove the concept of `Environment`. ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Manually tested: <img width="690" height="404" alt="Screenshot 2025-12-27 at 1 15 21 AM" src="https://github.com/user-attachments/assets/91bea787-d447-4abe-ad39-74eb581fa657" /> ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No.
1 parent 83769ae commit dac0dda

1 file changed

Lines changed: 0 additions & 46 deletions

File tree

‎file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala‎

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,52 +1156,6 @@ class DatasetResource {
11561156
withTransaction(context)(ctx => getDashboardDataset(ctx, did, None))
11571157
}
11581158

1159-
@GET
1160-
@Path("/file")
1161-
def retrieveDatasetSingleFile(
1162-
@QueryParam("path") pathStr: String
1163-
): Response = {
1164-
val decodedPathStr = URLDecoder.decode(pathStr, StandardCharsets.UTF_8.name())
1165-
1166-
withTransaction(context)(_ => {
1167-
val fileUri = FileResolver.resolve(decodedPathStr)
1168-
val streamingOutput = new StreamingOutput() {
1169-
override def write(output: OutputStream): Unit = {
1170-
val inputStream = DocumentFactory.openReadonlyDocument(fileUri).asInputStream()
1171-
try {
1172-
val buffer = new Array[Byte](8192) // buffer size
1173-
var bytesRead = inputStream.read(buffer)
1174-
while (bytesRead != -1) {
1175-
output.write(buffer, 0, bytesRead)
1176-
bytesRead = inputStream.read(buffer)
1177-
}
1178-
} finally {
1179-
inputStream.close()
1180-
}
1181-
}
1182-
}
1183-
1184-
val contentType = decodedPathStr.split("\\.").lastOption.map(_.toLowerCase) match {
1185-
case Some("jpg") | Some("jpeg") => "image/jpeg"
1186-
case Some("png") => "image/png"
1187-
case Some("csv") => "text/csv"
1188-
case Some("md") => "text/markdown"
1189-
case Some("txt") => "text/plain"
1190-
case Some("html") | Some("htm") => "text/html"
1191-
case Some("json") => "application/json"
1192-
case Some("pdf") => "application/pdf"
1193-
case Some("doc") | Some("docx") => "application/msword"
1194-
case Some("xls") | Some("xlsx") => "application/vnd.ms-excel"
1195-
case Some("ppt") | Some("pptx") => "application/vnd.ms-powerpoint"
1196-
case Some("mp4") => "video/mp4"
1197-
case Some("mp3") => "audio/mpeg"
1198-
case _ => "application/octet-stream" // default binary format
1199-
}
1200-
1201-
Response.ok(streamingOutput).`type`(contentType).build()
1202-
})
1203-
}
1204-
12051159
/**
12061160
* This method returns all owner user names of the dataset that the user has access to
12071161
*

0 commit comments

Comments
 (0)