Skip to content

Commit 150ea62

Browse files
xuang7chenlica
andauthored
feat: extend image preview to support WebP and GIF formats (apache#4120)
<!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> This PR adds support for WebP and GIF image formats in the dataset file preview feature. **Changes:** - Backend: - Added MIME type mappings for WebP (image/webp) and GIF (image/gif) in the `retrieveDatasetSingleFile `endpoint - Frontend: - Added WEBP and GIF to MIME_TYPES constants - Added size limits: 5 MB for WebP, 10 MB for GIF **Demonstration:** <img width="667" height="423" alt="demo" src="https://github.com/user-attachments/assets/86c73106-8f33-4121-a886-60996c013669" /> ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> apache#4119 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Manually tested, and existing automated tests passed. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No Signed-off-by: Xuan Gu <[email protected]> Co-authored-by: Chen Li <[email protected]>
1 parent b8bae84 commit 150ea62

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ export const MIME_TYPES = {
3030
JPEG: "image/jpeg",
3131
JPG: "image/jpeg",
3232
PNG: "image/png",
33+
WEBP: "image/webp",
34+
GIF: "image/gif",
3335
CSV: "text/csv",
3436
TXT: "text/plain",
3537
MD: "text/markdown",
@@ -55,6 +57,8 @@ export function getMimeType(filename: string): string {
5557
export const MIME_TYPE_SIZE_LIMITS_MB = {
5658
[MIME_TYPES.JPEG]: 5 * 1024 * 1024, // 5 MB
5759
[MIME_TYPES.PNG]: 5 * 1024 * 1024, // 5 MB
60+
[MIME_TYPES.WEBP]: 5 * 1024 * 1024, // 5 MB
61+
[MIME_TYPES.GIF]: 10 * 1024 * 1024, // 10 MB
5862
[MIME_TYPES.CSV]: 2 * 1024 * 1024, // 2 MB for text-based data files
5963
[MIME_TYPES.TXT]: 1 * 1024 * 1024, // 1 MB for plain text files
6064
[MIME_TYPES.MD]: 1 * 1024 * 1024, // 1 MB for MD files
@@ -200,6 +204,8 @@ export class UserDatasetFileRendererComponent implements OnInit, OnChanges, OnDe
200204
switch (blobMimeType) {
201205
case MIME_TYPES.PNG:
202206
case MIME_TYPES.JPEG:
207+
case MIME_TYPES.WEBP:
208+
case MIME_TYPES.GIF:
203209
this.displayImage = true;
204210
this.loadSafeURL(blob);
205211
break;

0 commit comments

Comments
 (0)