Skip to content

Benefits Denial's logistic regression also stops at max_iter #1237

Open

Description

@yakew7

Where: faircode/models.py, results/.

Current gap: #1152 names German Credit Lending and Healthcare Readmission, but a fit of the baseline and unawareness feature sets of Benefits Denial also raises ConvergenceWarning (the other three strategies do not), so the baseline rows of that audit depend on where the solver stopped.

Repro:

python3 -m pytest tests/test_benchmark_convergence.py -q -k 'Benefits'

Suggested approach: Decide with the two audits in #1152 whether to raise max_iter or scale inside the estimator, then rerun and record the movement with diff_results.py.

Done when: no benchmark fit of Benefits Denial warns and the entry in tests/test_benchmark_convergence.py is removed.

Activity

  1. added
    bugSomething isn't working
    reproducibilityBenchmark results, provenance and determinism
    on Oct 30, 2026
  2. pinned this issue on Oct 30, 2026
  3. unpinned this issue on Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreproducibilityBenchmark results, provenance and determinism

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions