Skip to content

Fix untranslatable Privateer plunder notification - #15862

Merged
yairm210 merged 1 commit into
yairm210:masterfrom
ibrahim-iqbal:fix/plunder-notification-translation
Oct 25, 2026
Merged

yairm210 merged 1 commit into
yairm210:masterfrom
ibrahim-iqbal:fix/plunder-notification-translation

Conversation

@ibrahim-iqbal

Copy link
Copy Markdown
Contributor

Fixes #15860

The stat branch of plunderFromDamage used a lowercase "your " prefix, so the notification never matched the Your [ourUnit] plundered [amount] [Stat] from [theirUnit] template entry and stayed untranslated. Translation tests pass; I have not triggered it in-game.

@SomeTroglodyte

Copy link
Copy Markdown
Collaborator

A single-bit fix! But good catch.

@yairm210
yairm210 merged commit dd9aabf into yairm210:master Oct 25, 2026
1 check passed
@ibrahim-iqbal
ibrahim-iqbal deleted the fix/plunder-notification-translation branch November 6, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Untranslatable string (Privateer)

3 participants