Repository navigation
Commit b6ac43e
committed
[fix](be) Keep the review fixes for vault sync logging and SDK key encoding
### What problem does this PR solve?
Related PR: apache#69605
Problem Summary: The previous commit "Preserve existing object storage behavior" returned three places to their state on master in order to keep this change a pure refactor. All three had been changed at a reviewer's request, so this commit restores them.
- A failed vault sync logs the status of the failing create or refresh again. On master the warning received the status of get_storage_vault_info, which is OK at that point, so a create failure, including the new configuration errors of this change, was logged with err OK.
- The AWS SDK enables RFC 3986 path encoding through SDKOptions before InitAPI again, the reader and writer constructors no longer set the process-wide flag, and the test that asserts the flag after initialization is back.
- The file cache microbench reader passes AWS_CONNECTION_TIMEOUT_MS again. The key on master, AWS_CONNECT_TIMEOUT_MS, is one that nothing reads, so the read client ran without the 3000 ms connection timeout of the write client.
The six files are identical to commit d3b60b3 again.
### Release note
None
### Check List (For Author)
- Test: Not compiled and not run in this commit; this machine has no BE build. The six files are byte-identical to d3b60b3, which was built and unit tested earlier. Build hygiene passed.
- Behavior changed: Yes. The vault sync warning shows the failing status, and strict RFC 3986 key encoding is on from AWS SDK initialization instead of from the first reader or writer.
- Does this need documentation: No1 parent e0caadd commit b6ac43e
6 files changed
Lines changed: 14 additions & 7 deletions
File tree
- be
- src
- cloud
- io
- fs
- tools
- util
- test/io
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
500 | 500 | | |
501 | 501 | | |
502 | 502 | | |
503 | | - | |
| 503 | + | |
504 | 504 | | |
505 | 505 | | |
506 | 506 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
96 | 95 | | |
97 | 96 | | |
98 | 97 | | |
99 | | - | |
100 | | - | |
101 | 98 | | |
102 | 99 | | |
103 | 100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
70 | 69 | | |
71 | 70 | | |
72 | 71 | | |
73 | | - | |
74 | 72 | | |
75 | 73 | | |
76 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1807 | 1807 | | |
1808 | 1808 | | |
1809 | 1809 | | |
1810 | | - | |
| 1810 | + | |
1811 | 1811 | | |
1812 | 1812 | | |
1813 | 1813 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
45 | 50 | | |
46 | 51 | | |
47 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
245 | 252 | | |
246 | 253 | | |
247 | 254 | | |
| |||
0 commit comments