Repository navigation
Commit 96f3b7e
[fix](be) Align object storage encoding, logging and benchmark settings
### What problem does this PR solve?
Related PR: apache#69605, apache#69082
Problem Summary: The integration branch differed from the reviewed child PR in three places. The file cache benchmark reader passed an unrecognized connection timeout key. The vault sync warning used the status of fetching the vault list after a create or refresh failed. Requests sent before the first reader or writer could use a different path encoding. Pass the recognized benchmark key, log the failing operation status and enable RFC 3986 encoding through the AWS SDK initialization options. Restore the SDK initialization regression test.
### Release note
The BE uses strict RFC 3986 path encoding from AWS SDK startup and reports the failing operation in vault sync warnings. The file cache benchmark applies its configured S3 connection timeout to reads.
### Check List (For Author)
- Test: Compared all three code paths and the encoding regression test with apache#69605 at b6ac43e. The six changed C++ files passed clang-format 16, the changed-line clang-tidy check and BE build hygiene.
- Behavior changed: Yes, as described in the release note.
- Does this need documentation: No1 parent 7435a28 commit 96f3b7e
6 files changed
Lines changed: 14 additions & 7 deletions
File tree
- be
- src
- cloud
- io
- fs
- tools
- util
- test/io
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
500 | 500 | | |
501 | 501 | | |
502 | 502 | | |
503 | | - | |
| 503 | + | |
504 | 504 | | |
505 | 505 | | |
506 | 506 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
99 | 98 | | |
100 | 99 | | |
101 | 100 | | |
102 | | - | |
103 | | - | |
104 | 101 | | |
105 | 102 | | |
106 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
72 | 71 | | |
73 | 72 | | |
74 | 73 | | |
75 | | - | |
76 | 74 | | |
77 | 75 | | |
78 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1807 | 1807 | | |
1808 | 1808 | | |
1809 | 1809 | | |
1810 | | - | |
| 1810 | + | |
1811 | 1811 | | |
1812 | 1812 | | |
1813 | 1813 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
45 | 50 | | |
46 | 51 | | |
47 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
245 | 252 | | |
246 | 253 | | |
247 | 254 | | |
| |||
0 commit comments