Repository navigation
fix: cancel click connections on pane click - #6068
Conversation
🦋 Changeset detectedLatest commit: 1d443ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thanks for your PR @snowyukitty . Could you add the same fix for Svelte Flow too? |
|
Added the Svelte Flow equivalent in 7abb6f0, including |
|
Thanks! Could you merge the two specs into one framework-agnostic spec? |
|
Combined the React and Svelte cases into one framework-agnostic |
|
Thanks! |
Fixes #5237.
Clicking the empty pane cancels a pending click-to-connect operation in both React Flow and Svelte Flow. The click-connect-end callback receives the final connection state before the start handle is cleared; normal pane clicks, panning, selection drags, node clicks and handle-to-handle connections keep their existing behavior.
The React and Svelte fixtures now run through one framework-agnostic
click-connect.spec.ts, using the configured framework's pane, viewport, selection, node, connection and edge selectors. The duplicate Svelte spec is removed. The patch changeset covers both packages.Validation on Linux, at this revision:
pnpm buildandpnpm typecheckpass.From the repository root:
This revision reruns the focused browser suite. The earlier full-suite results are historical: at
7abb6f0, React had 197 passing/25 skipped and Svelte had 187 passing/28 skipped/7 failures (six background-route 404s reproduced without the Svelte fix; the WebKit auto-pan case passed in an isolated rerun).