Repository navigation
Commit ff126a0
committed
fix(system): clamp extent:'parent' child to an unmeasured parent with an intrinsic size
calculateNodePosition built the parent extent from parentNode.measured
directly, so a child with extent: 'parent' was not clamped when the parent
declares an intrinsic size (width/initialWidth) but has not been measured
yet - the child could be dragged outside the parent. The reconcile path
(clampPositionToParent) already uses getNodeDimensions, so the two paths
were inconsistent.
Use getNodeDimensions (measured -> width -> initialWidth) for the parent
extent as well. Behavior is unchanged for measured parents and for parents
with no size at all.
Adds a regression test.1 parent dd308ab commit ff126a0
3 files changed
Lines changed: 56 additions & 2 deletions
File tree
- .changeset
- examples/react/cypress/components/utils
- packages/system/src/utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
430 | | - | |
431 | | - | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
432 | 437 | | |
433 | 438 | | |
434 | 439 | | |
| |||
0 commit comments