Skip to content

Commit d8edc77

Browse files
authored
Merge pull request #5955 from Jian-Zhang08/fix/minimap-onnodeclick-conditional-hook
fix(react): dont call useCallback conditionally in MiniMap
2 parents 68d16b0 + d77b902 commit d8edc77

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@xyflow/react": patch
3+
---
4+
5+
Fix `MiniMap` calling `useCallback` conditionally for `onNodeClick`.

‎packages/react/src/additional-components/MiniMap/MiniMap.tsx‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,12 @@ function MiniMapComponent<NodeType extends Node = Node>({
141141
}
142142
: undefined;
143143

144-
const onSvgNodeClick = onNodeClick
145-
? useCallback((event: MouseEvent, nodeId: string) => {
146-
const node: NodeType = store.getState().nodeLookup.get(nodeId)!.internals.userNode;
147-
onNodeClick(event, node);
148-
}, [])
149-
: undefined;
144+
const nodeClickHandler = useCallback((event: MouseEvent, nodeId: string) => {
145+
const node: NodeType = store.getState().nodeLookup.get(nodeId)!.internals.userNode;
146+
onNodeClick?.(event, node);
147+
}, [onNodeClick]);
148+
149+
const onSvgNodeClick = onNodeClick ? nodeClickHandler : undefined;
150150

151151
const _ariaLabel = ariaLabel ?? ariaLabelConfig['minimap.ariaLabel'];
152152

0 commit comments

Comments
 (0)