Skip to content

Commit 2acefb5

Browse files
committed
fix(react/store): reset functions #5991
1 parent b1b99e9 commit 2acefb5

2 files changed

Lines changed: 51 additions & 23 deletions

File tree

‎packages/react/src/store/initialState.ts‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,34 @@ const getInitialState = ({
155155

156156
onNodesChangeMiddlewareMap: new Map(),
157157
onEdgesChangeMiddlewareMap: new Map(),
158+
159+
onNodesDelete: undefined,
160+
onEdgesDelete: undefined,
161+
onDelete: undefined,
162+
onBeforeDelete: undefined,
163+
164+
onViewportChangeStart: undefined,
165+
onViewportChange: undefined,
166+
onViewportChangeEnd: undefined,
167+
168+
onNodeDragStart: undefined,
169+
onNodeDrag: undefined,
170+
onNodeDragStop: undefined,
171+
172+
onSelectionDragStart: undefined,
173+
onSelectionDrag: undefined,
174+
onSelectionDragStop: undefined,
175+
176+
onMoveStart: undefined,
177+
onMove: undefined,
178+
onMoveEnd: undefined,
179+
180+
onConnect: undefined,
181+
onConnectStart: undefined,
182+
onConnectEnd: undefined,
183+
184+
onClickConnectStart: undefined,
185+
onClickConnectEnd: undefined,
158186
};
159187
};
160188

‎packages/react/src/types/store.ts‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -103,24 +103,24 @@ export type ReactFlowStore<NodeType extends Node = Node, EdgeType extends Edge =
103103

104104
multiSelectionActive: boolean;
105105

106-
onNodeDragStart?: OnNodeDrag<NodeType>;
107-
onNodeDrag?: OnNodeDrag<NodeType>;
108-
onNodeDragStop?: OnNodeDrag<NodeType>;
106+
onNodeDragStart: OnNodeDrag<NodeType> | undefined;
107+
onNodeDrag: OnNodeDrag<NodeType> | undefined;
108+
onNodeDragStop: OnNodeDrag<NodeType> | undefined;
109109

110-
onSelectionDragStart?: OnSelectionDrag;
111-
onSelectionDrag?: OnSelectionDrag;
112-
onSelectionDragStop?: OnSelectionDrag;
110+
onSelectionDragStart: OnSelectionDrag | undefined;
111+
onSelectionDrag: OnSelectionDrag | undefined;
112+
onSelectionDragStop: OnSelectionDrag | undefined;
113113

114-
onMoveStart?: OnMoveStart;
115-
onMove?: OnMove;
116-
onMoveEnd?: OnMoveEnd;
114+
onMoveStart: OnMoveStart | undefined;
115+
onMove: OnMove | undefined;
116+
onMoveEnd: OnMoveEnd | undefined;
117117

118-
onConnect?: OnConnect;
119-
onConnectStart?: OnConnectStart;
120-
onConnectEnd?: OnConnectEnd;
118+
onConnect: OnConnect | undefined;
119+
onConnectStart: OnConnectStart | undefined;
120+
onConnectEnd: OnConnectEnd | undefined;
121121

122-
onClickConnectStart?: OnConnectStart;
123-
onClickConnectEnd?: OnConnectEnd;
122+
onClickConnectStart: OnConnectStart | undefined;
123+
onClickConnectEnd: OnConnectEnd | undefined;
124124

125125
connectOnClick: boolean;
126126
defaultEdgeOptions?: DefaultEdgeOptions;
@@ -129,16 +129,16 @@ export type ReactFlowStore<NodeType extends Node = Node, EdgeType extends Edge =
129129
fitViewOptions: FitViewOptions | undefined;
130130
fitViewResolver: ReturnType<typeof withResolvers<boolean>> | null;
131131

132-
onNodesDelete?: OnNodesDelete<NodeType>;
133-
onEdgesDelete?: OnEdgesDelete<EdgeType>;
134-
onDelete?: OnDelete;
135-
onError?: OnError;
132+
onNodesDelete: OnNodesDelete<NodeType> | undefined;
133+
onEdgesDelete: OnEdgesDelete<EdgeType> | undefined;
134+
onDelete: OnDelete | undefined;
135+
onError: OnError | undefined;
136136

137137
// event handlers
138-
onViewportChangeStart?: OnViewportChange;
139-
onViewportChange?: OnViewportChange;
140-
onViewportChangeEnd?: OnViewportChange;
141-
onBeforeDelete?: OnBeforeDelete<NodeType, EdgeType>;
138+
onViewportChangeStart: OnViewportChange | undefined;
139+
onViewportChange: OnViewportChange | undefined;
140+
onViewportChangeEnd: OnViewportChange | undefined;
141+
onBeforeDelete: OnBeforeDelete<NodeType, EdgeType> | undefined;
142142

143143
onSelectionChangeHandlers: OnSelectionChangeFunc<NodeType, EdgeType>[];
144144

@@ -148,7 +148,7 @@ export type ReactFlowStore<NodeType extends Node = Node, EdgeType extends Edge =
148148
autoPanSpeed: number;
149149
connectionRadius: number;
150150

151-
isValidConnection?: IsValidConnection<EdgeType>;
151+
isValidConnection: IsValidConnection<EdgeType> | undefined;
152152

153153
lib: string;
154154
debug: boolean;

0 commit comments

Comments
 (0)