This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Handle prettier with eslint #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eslint might depend on Prettier (https://github.com/prettier/eslint-plugin-prettier), so prettier config has to be copied into the linting directory - Both Eslint and Prettier might be configured as keys in package.json, so this file needs to also be imported
kasparsd
reviewed
Jan 16, 2020
6 tasks
adekbadek
added a commit
to Automattic/newspack-plugin
that referenced
this pull request
Feb 4, 2020
After xwp/wp-dev-lib#314 is merged and published, we can switch back to the official version.
adekbadek
added a commit
to Automattic/newspack-plugin
that referenced
this pull request
Feb 5, 2020
now using a fork of wp-dev-lib: after xwp/wp-dev-lib#314 is merged and a new version is published, we can switch back to the official distribution
adekbadek
added a commit
to Automattic/newspack-theme
that referenced
this pull request
Feb 5, 2020
After xwp/wp-dev-lib#314 is merged and published, we can switch back to the official version.
6 tasks
kasparsd
reviewed
Feb 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better Eslint config handling:
.eslintrc.yaml,.eslintrc.yml, should have been added in Handle multiple eslint config formats #313 ;) )package.json, so this file needs to also be imported