This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Path Excludes Pattern Fix #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MattGeri
commented
Jun 2, 2016
MattGeri
commented
- Added additional cat statement as if there are no changes in the diff outside the exclude, it doesn't work
* Added additional cat statement as if there are no changes in the diff outside the exclude, it doesn't work
check-diff.sh
Outdated
|
|
||
| if [ ! -z "$PATH_EXCLUDE_PATTERN" ]; then | ||
| cat "$TEMP_DIRECTORY/paths-scope" | grep -E -v "$PATH_EXCLUDE_PATTERN" > "$TEMP_DIRECTORY/excluded-paths-scope" | ||
| cat "$TEMP_DIRECTORY/paths-scope" | grep -E -v "$PATH_EXCLUDE_PATTERN" | cat - > "$TEMP_DIRECTORY/excluded-paths-scope" |
Contributor
There was a problem hiding this comment.
Try adding the -q arg for grep instead of masking the failure exit code via piping into cat -
Contributor
There was a problem hiding this comment.
Nevermind, it doesn't work.
* Updated name to EXCLUDES (previously EXCLUDE) * Implemented a default pattern to exclude the vendor directory * Remove the vendor ignore from YUI as already excluded on a global level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.