This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Ignore node_modules symlinks when installing npm.
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's somewhat of a hack that we're using a symlinked |
westonruter
added a commit
to xwp/wp-customize-posts
that referenced
this pull request
May 25, 2016
…odules gets created to fix ESLint checks xwp/wp-dev-lib@046c3c5...4c79f77 d14fb0f Fix activation of plugins via WP_TEST_ACTIVATED_PLUGINS config 9a6eaba Merge pull request xwp/wp-dev-lib#176 from branch bugfix/test-activated-plugins e34026e Ignore `node_modules` symlinks when installing `npm`. 6242f95 Merge pull request xwp/wp-dev-lib#177 from branch bugfix/ignore-node-modules-symlink c05837c Define Paths * Define paths to the current WP install instead of using the wordpress-develop paths as per the tests bootstrap ad82ec3 Define WP_CONTENT_DIR and WP_PLUGIN_DIR 4c79f77 Ensure symlink for node_modules gets created to fix ESLint checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having symbolic link to
node_modulesin the project root (as e.g. in case of a client's plugins using globalnode_modulesvia symlink) generates Travis error:After removing
node_modulessymlinks in plugins, builds are okay.However, having symlink in plugin's directory facilitates development, so it's not a best idea to remove them completely. In this case, I've modified
check-diff.shscript to go ahead and ignore symlink. This waynpmshould be installed in each Travis build.I'm open to any developer having a look and commenting/merging this into
master.@westonruter - I'm assigning this to you primarily, as you already saw my struggles with this issue.