This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Show list of settings in snapshot in excerpt #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@valendesigns I found lots of references to |
Contributor
|
The reference to dirty is to add only settings to the snapshot that are dirty. It doesn't have anything to do with dirty or full scope during the playback. |
Contributor
Author
|
We shouldn't be adding things to a snapshot if they aren't dirty to begin with though. |
Contributor
|
That's what the dirty check in set was for. 😀 |
Contributor
Author
|
@valendesigns I mean from the JS side of things. We shouldn't be sending a request that contains both dirty and non-dirty settings, right? |
Contributor
Author
|
@valendesigns there, see deb0ddd. |
Contributor
|
Yes, that looks right now.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45.
Fixes #42.