Improve WP Admin UI #38

westonruter · 2016-06-09T06:26:39Z

No description provided.

valendesigns · 2016-06-09T07:05:23Z

php/class-customize-snapshot-manager.php

 	function setup_metaboxes() {
 		$id = self::POST_TYPE;
-		$title = __( 'Data', 'customize-snapshots' );
+		$title = __( 'Data', 'customize-snapshot' );


The text domain is customize-snapshots

valendesigns · 2016-06-09T07:47:53Z

php/class-plugin.php

 			$allcaps['customize_publish'] = true;
 		}

+		// Grant all customize snapshot caps which weren't explicitly disallowed to users who can customize.


This is causing test failures.

I restored the initial cap check in ab6ca42. Tests are passing now.

…omize snapshots We'll need a different mechanism to prevent mutating published (non-future) snapshots

valendesigns · 2016-06-09T20:42:15Z

php/class-customize-snapshot-manager.php

+			'<p><a href="%s" class="button button-secondary">%s</a></p>',
+			esc_url( $customize_url ),
+			esc_html__( 'Open in Customizer', 'customize-snapshots' )
+		);


This commit makes me happy 😄

valendesigns · 2016-06-09T20:47:13Z

@westonruter When you publish the snapshot all the settings disappear from the metabox

valendesigns · 2016-06-09T20:58:11Z

Oh they are hidden after published. So we need to remove the checkbox toggle and hidden attribute for published snapshots so all the settings display

westonruter · 2016-06-09T20:59:13Z

@valendesigns I think the problem is that all of the settings get sent with dirty: false at the moment of Publish. We should preserve the original dirty state.

…tely after saving a snapsot

…mmutable

…ed snapshots

…omize-snapshots into feature/wp-admin

…napshots into feature/wp-admin

…b#187 from branch bugfix/nested-phpunit-support2 xwp/wp-dev-lib@159119b...0f3058b

westonruter · 2016-06-09T22:11:05Z

@valendesigns ok, ready for you to review.

valendesigns · 2016-06-09T23:09:20Z

@westonruter I think we should hide the "Save Draft" button or change the customize button to "Edit" so it fits in the space. Thoughts?

valendesigns · 2016-06-09T23:12:10Z

We also need to handle the publish button so the Snapshot updates the front-end. Otherwise scheduling will not work.

valendesigns · 2016-06-09T23:43:00Z

@westonruter An issue with the updated state replacement JS is that the ? is being left behind when there are no params in the url. It should check that there are params and remove the question mark if there aren't any.

westonruter · 2016-06-09T23:47:37Z

@valendesigns

I think we should hide the "Save Draft" button or change the customize button to "Edit" so it fits in the space. Thoughts? We also need to handle the publish button so the Snapshot updates the front-end. Otherwise scheduling will not work.

Actually, perhaps we should just hide the publish box entirely. This would be what #15 would implement, and at that time, the publish button could be restored.

westonruter · 2016-06-09T23:59:37Z

I think I know what to do. We can just remove the publish_posts cap for now and it will just work 😄

westonruter · 2016-06-10T00:13:10Z

@valendesigns oh, and you know what? Now with b3ea60a it would be sweet if when a user lacks customize_publish capability, in addition to a Save button there could be a “Submit” button that serves the same purpose as the “Submit for Review” button when a user wants to submit a post as pending status:

valendesigns · 2016-06-10T00:31:39Z

So it makes the publish button say submit for review?

westonruter · 2016-06-10T00:42:00Z

@valendesigns yeah, try this: feature/wp-admin...feature/submit-for-review

…orted

westonruter · 2016-06-10T21:10:35Z

@valendesigns I merged feature/submit-for-review into this branch. I'm feeling really good about it now. I think I addressed all of your concerns.

…cation

westonruter added 2 commits June 8, 2016 22:17

Add author post type support

d053407

Remove Add New post link for snapshots; harden capabilities

fbf9ff4

westonruter assigned valendesigns Jun 9, 2016

westonruter force-pushed the feature/wp-admin branch from 92cedf8 to 9317cf6 Compare June 9, 2016 06:27

Show only dirty settings in edit post screen; use UUID as metabox title

083debb

westonruter force-pushed the feature/wp-admin branch from 9317cf6 to 083debb Compare June 9, 2016 06:28

Restore UUID as heading so it is selectable

910265d

valendesigns reviewed Jun 9, 2016
View reviewed changes

Fix text domain

4e2ba3c

valendesigns reviewed Jun 9, 2016
View reviewed changes

valendesigns and others added 6 commits June 9, 2016 01:08

Allow non-dirty settings to be revealed

fa11939

Check that array index isset

7b5152c

Restore initial customize check

ab6ca42

Restore edit_published_posts and delete_published_posts caps for cust…

a8c6c20

…omize snapshots We'll need a different mechanism to prevent mutating published (non-future) snapshots

Add quick edit link to open Customizer

152589c

Add Open in Customizer button to edit snapshot screen

c2e9230

valendesigns reviewed Jun 9, 2016
View reviewed changes

Hide Snapshot Customize links if status is publish

898542a

westonruter added 8 commits June 9, 2016 14:07

Add missing js-doc return tags

3815b26

Set isPreview once snapshot saved; send original _dirty state

4d4a1fe

Make sure Published button can be re-disabled when publishing immedia…

ed47f1c

…tely after saving a snapsot

Move Open in Customizer button to misc publish box

8bcdce0

Move Open in Customizer button to post_submitbox_minor_actions

37715bc

Remove publish metabox got published snapshots since they should be i…

9755a6a

…mmutable

Hide trash and quick edit links with view instead of edit for publish…

8a4881a

…ed snapshots

Disable author metabox for published snapshots

ad595a7

westonruter added 3 commits June 9, 2016 14:50

Merge branch 'bugfix/replace-state' of https://github.com/xwp/wp-cust…

c55bb68

…omize-snapshots into feature/wp-admin

Merge branch 'release/0.4.0' of https://github.com/xwp/wp-customize-s…

cf6ecf8

…napshots into feature/wp-admin

Update wp-dev-lib 159119b...0f3058b: Merge pull request xwp/wp-dev-li…

87c4ce6

…b#187 from branch bugfix/nested-phpunit-support2 xwp/wp-dev-lib@159119b...0f3058b

Trim trailing question mark

390cf9c

Remove publish_posts cap until #15 is implmented

b3ea60a

Introduce a submit button if user cannot publish

195f4de

westonruter added 8 commits June 10, 2016 13:28

Prevent post_name from being striped when submitting for review

d321212

Move Open in Customizer back to metabox until publish metabox is supp…

6ebf4d7

…orted

Hide Customize quicklink if user cannot edit post

5c64c5b

Hide edit bulk action, quick edit, and author metabox

3ff6158

Restore delete quick edit link

e2833a2

Add post info from submitbox to data metabox

6fa5ff9

Restrict editing and deleting others' posts

eae3c6d

Merge branch 'feature/submit-for-review' into feature/wp-admin

a579fa8

westonruter and others added 2 commits June 10, 2016 14:36

Add test for preserving post name when submitting as pending

f41c35d

Fix the perms message and add new changeButton method to reduce dupli…

a7a4009

…cation

valendesigns merged commit 181317a into release/0.4.0 Jun 10, 2016

valendesigns deleted the feature/wp-admin branch June 11, 2016 00:05

westonruter modified the milestone: 0.4.0 Jun 12, 2016

Improve WP Admin UI #38

Improve WP Admin UI #38

Uh oh!

Conversation

westonruter commented Jun 9, 2016

Uh oh!

valendesigns Jun 9, 2016

Choose a reason for hiding this comment

Uh oh!

valendesigns Jun 9, 2016

Choose a reason for hiding this comment

Uh oh!

westonruter Jun 9, 2016

Choose a reason for hiding this comment

Uh oh!

valendesigns Jun 9, 2016

Choose a reason for hiding this comment

Uh oh!

valendesigns commented Jun 9, 2016

Uh oh!

valendesigns commented Jun 9, 2016

Uh oh!

westonruter commented Jun 9, 2016

Uh oh!

westonruter commented Jun 9, 2016

Uh oh!

valendesigns commented Jun 9, 2016

Uh oh!

valendesigns commented Jun 9, 2016

Uh oh!

valendesigns commented Jun 9, 2016

Uh oh!

westonruter commented Jun 9, 2016

Uh oh!

westonruter commented Jun 9, 2016

Uh oh!

westonruter commented Jun 10, 2016

Uh oh!

valendesigns commented Jun 10, 2016

Uh oh!

westonruter commented Jun 10, 2016

Uh oh!

westonruter commented Jun 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants