This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Fix previewing widgets in snapshots #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
changed the title
westonruter
referenced
this pull request
Jun 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CustomizeSnapshots\Customize_Snapshot_Manager::can_preview()method gets called alter anyway in\CustomizeSnapshots\Customize_Snapshot_Manager::preview()before the setting actually gets previewed. So we don't need to call it earlier. We can just populate the unsanitized post values as early as we can, and then the Customizer will pick up the settings on its own.Nevertheless, I think we can actually get rid of
can_previewaltogether. See #26.Fixes #33.