This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Improve migration #119
Merged
Improve migration #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change wp_update_post to update via $wpdb to skip extra hooks, change ajax limit to 5 to avoid large snapshot migration timeouts, improve migration verbosity.
valendesigns
suggested changes
Feb 24, 2017
| \WP_CLI::success( count( $ids ) . ' ' . __( 'posts migrated:', 'customize-snapshots' ) . ' ' . implode( ',', $ids ) ); | ||
| $ids = $migrate_obj->changeset_migrate( -1, true ); | ||
| \WP_CLI::success( __( 'Posts migrated:', 'customize-snapshots' ) . ' ' . implode( ',', $ids ) ); | ||
| \WP_CLI::success( 'Total ' . count( $ids ) . ' ' . __( 'posts migrated.', 'customize-snapshots' ) ); |
Contributor
There was a problem hiding this comment.
Change the string to something like this:
\WP_CLI::success( sprintf( __( 'Total posts migrated: %s', 'customize-snapshots' ), count( $ids ) ) );
| } | ||
|
|
||
| if ( $is_doing_cli ) { | ||
| \WP_CLI::log( __( 'Migrating', 'customize-snapshots' ) . ' ' . count( $query->posts ) . __( ' snapshots into changeset', 'customize-snapshots' ) ); |
Contributor
There was a problem hiding this comment.
Change to:
\WP_CLI::log( sprintf( __( 'Migrating %s Snapshots into Changeset', 'customize-snapshots' ), count( $query->posts ) ) );
| $success = $this->migrate_post( $id ); | ||
| if ( $is_doing_cli ) { | ||
| if ( $success ) { | ||
| \WP_CLI::success( __( 'Migrated post', 'customize-snapshots' ) . ' ' . $id . '.' ); |
Contributor
There was a problem hiding this comment.
Change to:
\WP_CLI::success( sprintf( __( 'Migrated post %s.', 'customize-snapshots' ), $id ) );
| if ( $success ) { | ||
| \WP_CLI::success( __( 'Migrated post', 'customize-snapshots' ) . ' ' . $id . '.' ); | ||
| } else { | ||
| \WP_CLI::error( __( ' Failed to migrate', 'customize-snapshots' ) . ' ' . $id . '.' ); |
Contributor
There was a problem hiding this comment.
Change to:
\WP_CLI::error( sprintf( __( 'Failed to migrate post %s.', 'customize-snapshots' ), $id ) );
Contributor
|
Woops! Sorry @valendesigns. @PatelUtkarsh please follow-up with a new PR to address ☝️ feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change wp_update_post to update via $wpdb to skip extra hooks,
change ajax limit to 5 to avoid large snapshot migration timeouts,
improve migration verbosity.