This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Prevent extra section params from being passed along to previewUrl #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatelUtkarsh
approved these changes
Oct 5, 2016
westonruter
deleted the
bugfix/remove-additional-query-params-from-post-section-navigation-link
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the
section.paramsother thanpost_idandpost_typefrom being included in preview URL. Prevents URLs from being previewed that look like:http://wp.example.com/?preview=true&p=6189&id=post%5Bpost%5D%5B6189%5D&panel=posts%5Bpost%5D&active=true&customizeAction=Customizing%2B%E2%96%B8%2BPosts&title=Hello%2BWorld&description=&priority=100&type=default&content=&instanceNumber=
The issue happened specifically when you clicked the post navigation link or if you jumped to a post via the select2 and the post was not visible in the preview: