This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Sync page changes to Static Front Page section controls; prevent same page from being used as both page for posts and page on front#270
Merged
westonruter merged 6 commits intodevelopfrom Sep 17, 2016
Conversation
…stomize-posts into feature/sync-page-changes-to-static-front-page-section-controls
…e_on_front & page_for_posts * Ensure that the settings associated with the dropdown-pages controls get cleared if trashed pages are selected. * Show "(no title)" in option if no page title is supplied. * Use jQuery selectors instead of iteration. * Show (Trashed) with pages in dropdown-pages options that are disabled ].
westonruter
commented
Sep 16, 2016
js/customize-post-section.js
Outdated
| pageOption.text( optionText ); | ||
| } | ||
|
|
||
| // @todo In the case of page_on_front and page_for_posts, this should only be done if it wouldn't mean that they can be set to the same. See https://github.com/xwp/wp-customize-object-selector/pull/22 |
Contributor
Author
There was a problem hiding this comment.
This can be handled with a new integration specific for these two settings, at the component level itself.
westonruter
changed the title
westonruter
deleted the
feature/sync-page-changes-to-static-front-page-section-controls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #190.
Fixes #153.