Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Use notification.setting instead of notification.data.setting #238

Merged
westonruter merged 1 commit into from
Sep 1, 2016
Merged

Use notification.setting instead of notification.data.setting #238

westonruter merged 1 commit into from
Sep 1, 2016

Conversation

@westonruter
Copy link
Contributor

@westonruter westonruter commented Sep 1, 2016

@westonruter westonruter added this to the 0.8 milestone Sep 1, 2016
@westonruter westonruter added the bug label Sep 1, 2016
@westonruter
Copy link
Contributor Author

westonruter commented Sep 1, 2016

Since notification.data && notification.data.setting doesn't work in core today, there's no harm in merging a check for notification.setting now, even though #37890 isn't merged.

@westonruter westonruter merged commit 57a5703 into develop Sep 1, 2016
@westonruter westonruter deleted the bugfix/notification-setting branch September 1, 2016 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

1 participant

@westonruter