This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Editor Resize #149
Merged
Editor Resize #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds vertical resize capability to post editor pane
remove unused vars
- descriptive var names - add editorResize function - keep it DRY - adjust min/max to give more resize freedom - add window resize listerner to not allow editor controls to push off screen - change css class/id names for drag bar and drag resize helper
- change class and id names for drag bar and drag bar helper
- change drag bar class name to be more descriptive
Updated file from master branch instead of develop
…ingram3541/wp-customize-posts into pingram3541-feature/editor-vertical-resize
Closed
This prevents the event handler bodies from running for every post section even when they are not expanded
| editorFrame.css( 'height', args.height - args.components ); | ||
| collapse.css( 'bottom', args.height + 8 ); | ||
|
|
||
| if ( 56 > windowHeight - args.height ) { |
There was a problem hiding this comment.
What is 56? Can we assign it to a named variable so we can understand what is being referred to here?
|
@pingram3541 could you please advise on appropriate variable names for those magic-number literals? For more information, see http://eslint.org/docs/rules/no-magic-numbers |
|
@westonruter I added them
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vertical resize capability to post editor pane
Fixes #136