This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Add all postmeta settings for registered types not just the ones actually referenced #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue whereby you add a control for a given postmeta but the control won't appear unless the postmeta is explicitly referenced via a
get_post_meta()call sine this is when the setting gets added and thus exported from the preview to the pane.While it could be argued that it is expected behavior for a control to not appear if the postmeta is not referenced in the preview, there may very well be postmeta manipulated for a given post that doesn't appear in the preview since you may be on an archive page.