Should not try to use a semaphore when we've been asked for unlimited threads

bradwilson · bradwilson · commit d73cdefc96ac · 2024-04-19T22:13:47.000-07:00
diff --git a/src/xunit.execution/Sdk/Frameworks/Runners/XunitTestAssemblyRunner.cs b/src/xunit.execution/Sdk/Frameworks/Runners/XunitTestAssemblyRunner.cs
@@ -267,6 +267,9 @@ protected override async Task<RunSummary> RunTestCollectionsAsync(IMessageBus me
 
         private void SetupParallelSemaphore(int maxParallelThreads)
         {
+            if (maxParallelThreads < 1)
+                return;
+
             parallelSemaphore = new SemaphoreSlim(maxParallelThreads);
 
 #if NETSTANDARD

Original file line number	Diff line number	Diff line change
`@@ -267,6 +267,9 @@ protected override async Task<RunSummary> RunTestCollectionsAsync(IMessageBus me`
`267`	`267`
`268`	`268`	`private void SetupParallelSemaphore(int maxParallelThreads)`
`269`	`269`	`{`
	`270`	`+ if (maxParallelThreads < 1)`
	`271`	`+ return;`
	`272`	`+`
`270`	`273`	`parallelSemaphore = new SemaphoreSlim(maxParallelThreads);`
`271`	`274`
`272`	`275`	`#if NETSTANDARD`