Unit tests to ensure equality assertions with sets + comparer func throw an exception

bradwilson · bradwilson · commit 51851a64edb6 · 2023-12-06T12:07:52.000-08:00
diff --git a/src/xunit.assert/Asserts b/src/xunit.assert/Asserts
@@ -1 +1 @@
-Subproject commit 6e0a7cd70648f8bd1a94e08a827aae1297d5a775
+Subproject commit 1dab747d384b6f1512df50f04cf2817864657f7a
diff --git a/test/test.xunit.assert/Asserts/EqualityAssertsTests.cs b/test/test.xunit.assert/Asserts/EqualityAssertsTests.cs
@@ -1308,6 +1308,21 @@ public void DifferentTypes_NotEqual()
 					ex.Message
 				);
 			}
+
+			[Fact]
+			public void ComparerFunc_Throws()
+			{
+				var expected = new HashSet<string> { "bar" };
+				var actual = new HashSet<string> { "baz" };
+
+				var ex = Record.Exception(() => Assert.Equal(expected, actual, (string l, string r) => true));
+
+				Assert.IsType<EqualException>(ex);
+				Assert.Equal(
+					"Assert.Equal() Failure: During comparison of two collections, GetHashCode was called, but only a comparison function was provided. This typically indicates trying to compare two sets with an item comparison function, which is not supported. For more information, see https://xunit.net/docs/hash-sets-vs-linear-containers",
+					ex.Message
+				);
+			}
 		}
 
 		public class Sets
@@ -1475,6 +1490,21 @@ void assertFailure(Action action)
 				assertFailure(() => Assert.Equal(expected, (ISet<string>)actual));
 				assertFailure(() => Assert.Equal(expected, (object)actual));
 			}
+
+			[Fact]
+			public void ComparerFunc_Throws()
+			{
+				var expected = new NonGenericSet { "bar" };
+				var actual = new HashSet<string> { "baz" };
+
+				var ex = Record.Exception(() => Assert.Equal(expected, actual, (string l, string r) => true));
+
+				Assert.IsType<EqualException>(ex);
+				Assert.Equal(
+					"Assert.Equal() Failure: During comparison of two collections, GetHashCode was called, but only a comparison function was provided. This typically indicates trying to compare two sets with an item comparison function, which is not supported. For more information, see https://xunit.net/docs/hash-sets-vs-linear-containers",
+					ex.Message
+				);
+			}
 		}
 
 		public class KeyValuePair
@@ -3285,6 +3315,21 @@ public void DifferentTypes_NotEqual()
 
 				Assert.NotEqual(expected, actual);
 			}
+
+			[Fact]
+			public void ComparerFunc_Throws()
+			{
+				var expected = new HashSet<string> { "bar" };
+				var actual = new HashSet<string> { "baz" };
+
+				var ex = Record.Exception(() => Assert.NotEqual(expected, actual, (string l, string r) => false));
+
+				Assert.IsType<NotEqualException>(ex);
+				Assert.Equal(
+					"Assert.NotEqual() Failure: During comparison of two collections, GetHashCode was called, but only a comparison function was provided. This typically indicates trying to compare two sets with an item comparison function, which is not supported. For more information, see https://xunit.net/docs/hash-sets-vs-linear-containers",
+					ex.Message
+				);
+			}
 		}
 
 		public class Sets
@@ -3439,6 +3484,21 @@ public void TwoGenericSubClass_NotEqual()
 				Assert.NotEqual(expected, (ISet<string>)actual);
 				Assert.NotEqual(expected, (object)actual);
 			}
+
+			[Fact]
+			public void ComparerFunc_Throws()
+			{
+				var expected = new NonGenericSet { "bar" };
+				var actual = new HashSet<string> { "baz" };
+
+				var ex = Record.Exception(() => Assert.NotEqual(expected, actual, (string l, string r) => false));
+
+				Assert.IsType<NotEqualException>(ex);
+				Assert.Equal(
+					"Assert.NotEqual() Failure: During comparison of two collections, GetHashCode was called, but only a comparison function was provided. This typically indicates trying to compare two sets with an item comparison function, which is not supported. For more information, see https://xunit.net/docs/hash-sets-vs-linear-containers",
+					ex.Message
+				);
+			}
 		}
 
 		public class Strings
