Add PackageDownload for Microsoft.NETFramework.ReferenceAssemblies.net452 to make FSharpAcceptanceTestAssembly work

bradwilson · bradwilson · commit 028866f82155 · 2023-06-28T17:15:27.000-07:00
diff --git a/test/test.utility/Compilation/FSharpAcceptanceTestAssembly.cs b/test/test.utility/Compilation/FSharpAcceptanceTestAssembly.cs
@@ -15,14 +15,14 @@ protected FSharpAcceptanceTestAssembly(string basePath)
     protected override IEnumerable<string> GetStandardReferences()
     {
         var homeDir = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
-        var fxDir = $@"{homeDir}\.nuget\packages\microsoft.netframework.referenceassemblies.net452\1.0.2\build\.NETFramework\v4.5.2\";
+        // If you update this path, make sure to update the PackageDownload in test.utility.csproj as well
+        var fxDir = $@"{homeDir}\.nuget\packages\microsoft.netframework.referenceassemblies.net452\1.0.3\build\.NETFramework\v4.5.2\";
         var mscorlib = $@"{fxDir}mscorlib.dll";
         var sysRuntime = $@"{fxDir}Facades\System.Runtime.dll";
 
         return new[] { mscorlib, sysRuntime, "xunit.abstractions.dll" };
     }
 
-
     protected override void Compile(string code, string[] references)
     {
         var sourcePath = Path.GetTempFileName() + ".fs";
diff --git a/test/test.utility/test.utility.csproj b/test/test.utility/test.utility.csproj
@@ -23,6 +23,11 @@
     <PackageReference Include="System.ComponentModel.TypeConverter" Version="4.3.0" />
   </ItemGroup>
 
+  <ItemGroup>
+    <!-- Needed by FSharpAcceptanceTestAssembly -->
+    <PackageDownload Include="Microsoft.NETFramework.ReferenceAssemblies.net452" Version="[1.0.3]" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\..\src\xunit.assert\xunit.assert.csproj" />
     <ProjectReference Include="..\..\src\xunit.execution\xunit.execution.csproj" />

Original file line number	Diff line number	Diff line change
`@@ -15,14 +15,14 @@ protected FSharpAcceptanceTestAssembly(string basePath)`
`15`	`15`	`protected override IEnumerable<string> GetStandardReferences()`
`16`	`16`	`{`
`17`	`17`	`var homeDir = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);`
`18`		`- var fxDir = $@"{homeDir}\.nuget\packages\microsoft.netframework.referenceassemblies.net452\1.0.2\build\.NETFramework\v4.5.2\";`
	`18`	`+ // If you update this path, make sure to update the PackageDownload in test.utility.csproj as well`
	`19`	`+ var fxDir = $@"{homeDir}\.nuget\packages\microsoft.netframework.referenceassemblies.net452\1.0.3\build\.NETFramework\v4.5.2\";`
`19`	`20`	`var mscorlib = $@"{fxDir}mscorlib.dll";`
`20`	`21`	`var sysRuntime = $@"{fxDir}Facades\System.Runtime.dll";`
`21`	`22`
`22`	`23`	`return new[] { mscorlib, sysRuntime, "xunit.abstractions.dll" };`
`23`	`24`	`}`
`24`	`25`
`25`		`-`
`26`	`26`	`protected override void Compile(string code, string[] references)`
`27`	`27`	`{`
`28`	`28`	`var sourcePath = Path.GetTempFileName() + ".fs";`