Only show char codes for parsing data on trace#5425
Merged
Conversation
Tyriar
requested changes
Oct 22, 2025
src/common/InputHandler.ts
Outdated
| this._logService.debug(`parsing data ${typeof data === 'string' ? ` "${data}"` : ` "${Array.prototype.map.call(data, e => String.fromCharCode(e)).join('')}"`}`); | ||
| this._logService.trace(`parsing data (codes)`, () => typeof data === 'string' | ||
| ? data.split('').map(e => e.charCodeAt(0)) | ||
| : Array.from(data) |
Member
Author
There was a problem hiding this comment.
Facts!! You're right.. data is Uint8Array, doing Array.from(data) feels like complete waste.
When we use logService to print, it would look identical, right?
I dont think I ever saw Uint8Array(5) that prepends these characters in the log
Tyriar
requested changes
Oct 23, 2025
Tyriar
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously did: #5420 to log character codes for
sending dataonly on trace.Should we do the same for
parsing data?Otherwise, the debug level for terminal output still is filled with bunch of character codes.