Refactor search addon into multiple files, add unit tests#5406
Merged
Tyriar merged 10 commits intoxtermjs:masterfrom Sep 26, 2025
Merged
Refactor search addon into multiple files, add unit tests#5406Tyriar merged 10 commits intoxtermjs:masterfrom
Tyriar merged 10 commits intoxtermjs:masterfrom
Conversation
- Extract SearchEngine for core search algorithms - Extract DecorationManager for visual decorations - Extract SearchState for state management - Extract SearchResultTracker for result tracking - Simplify SearchAddon by delegating to components - Improve modularity and maintainability
- Remove unnecessary inline comments from unit tests - Add descriptive assertion messages where appropriate - Follow coding guidelines for test comment usage
- Remove export from IHighlight and IMultiHighlight interfaces - Remove export from ISelectedDecoration interface - Remove export from ISearchPosition interface - Keep ISearchResult exported as it's used across multiple files - Make ISelectedDecoration extend IDisposable for consistency
- Add coding guidelines section to copilot instructions - Specify rule about avoiding comments in unit tests - Add lint-fix npm script for auto-fixing ESLint issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.